Remove redundant cases with UnApply

scala · May 7, 2024 · bd3ee30 · bd3ee30
1 parent 3d422cd
commit bd3ee30
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala b/presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala
@@ -68,6 +68,8 @@ class Completions(
         false
       case (_: (Import | Export)) :: _ => false
       case _ :: (_: (Import | Export)) :: _ => false
+      // UnApply has patterns included in MatchCaseCompletions
+      case _ :: (_: UnApply) :: _ => false
       case _ => true
 
   private lazy val isNew: Boolean =

diff --git a/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionSuite.scala b/presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionSuite.scala
@@ -642,7 +642,6 @@ class CompletionSuite extends BaseCompletionSuite:
           |}
           |""".stripMargin,
       """|Some(value) scala
-         |Some[A](value: A): Some[A]
          |Some scala
          |""".stripMargin
     )
@@ -653,7 +652,6 @@ class CompletionSuite extends BaseCompletionSuite:
           |}
           |""".stripMargin,
       """|Some(value) scala
-         |Some[A](value: A): Some[A]
          |Some scala
          |""".stripMargin
     )
@@ -664,7 +662,6 @@ class CompletionSuite extends BaseCompletionSuite:
           |}
           |""".stripMargin,
       """|Some(value) scala
-         |Some[A](value: A): Some[A]
          |Some scala
          |""".stripMargin
     )
@@ -676,7 +673,6 @@ class CompletionSuite extends BaseCompletionSuite:
           |    case Some(Test.Neste@@)
           |""".stripMargin,
       """|NestedClass(x) test.Test
-         |NestedClass(x: Int): NestedClass
          |NestedClass test.Test
          |""".stripMargin
     )
@@ -690,7 +686,6 @@ class CompletionSuite extends BaseCompletionSuite:
           |""".stripMargin,
       """|Some(value) scala
          |Some scala
-         |Some[A](value: A): Some[A]
          |Some scala
          |""".stripMargin
     )