Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL warns terminal provider jna has been deprecated #22201

Closed
Gedochao opened this issue Dec 12, 2024 · 0 comments · Fixed by #22205
Closed

REPL warns terminal provider jna has been deprecated #22201

Gedochao opened this issue Dec 12, 2024 · 0 comments · Fixed by #22205
Assignees
Labels
area:command line Issues tied to how our launchers handle on the command line. area:repl itype:bug

Comments

@Gedochao
Copy link
Contributor

Compiler version

3.6.2

Reproduction steps

Seems not to happen on MacOS for some reason.
Reproduced on Ubuntu 22.04

cs launch scala:3.6.2 -M dotty.tools.repl.Main

or just

scala

This being reproducible with dotty.tools.repl.Main indicates it's not tied with the runner/CLI/wrapper script.

Output

$ scala 
Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=1
Dec 12, 2024 2:08:51 PM org.jline.utils.Log logr
WARNING: The terminal provider jna has been deprecated, check your configuration. This warning can be disabled by setting the system property org.jline.terminal.disableDeprecatedProviderWarning to true.
Welcome to Scala 3.6.2 (11.0.25, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.
                                                                                                                                                                                                         
scala> 

Expectation

No warning about the terminal provider should be printed.

Extra context

@Gedochao Gedochao added itype:bug area:repl area:command line Issues tied to how our launchers handle on the command line. labels Dec 12, 2024
@SethTisue SethTisue self-assigned this Dec 12, 2024
WojciechMazur added a commit that referenced this issue Dec 19, 2024
…27.1 (was 3.27.0) (#22205)

as per the https://github.com/jline/jline3 readme
 
and as per discussion and linked items on #22201 

fixes #22201

note that as far as I can tell, the stuff I removed from
libexec/common-shared is dead code

@philwalk dunno if you're still around but judging from #12405 you might
be a good reviewer here

note that I believe we _don't_ need to also port
scala/scala#10889 here, since we are already
using separate JLine JARs rather than the all-in-one JAR

I've chosen not to upgrade all the way to JLine 3.28.0 at the moment, as
it is quite new (2 days ago) and doesn't appear to have any fixes that
might be critical.
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this issue Jan 15, 2025
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this issue Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:command line Issues tied to how our launchers handle on the command line. area:repl itype:bug
Projects
None yet
2 participants