Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden canAssign #15963

Merged
merged 1 commit into from
Sep 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Typer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer

def canAssign(sym: Symbol) =
sym.is(Mutable, butNot = Accessor) ||
ctx.owner.isPrimaryConstructor && !sym.is(Method) && sym.owner == ctx.owner.owner ||
ctx.owner.isPrimaryConstructor && !sym.is(Method) && sym.maybeOwner == ctx.owner.owner ||
// allow assignments from the primary constructor to class fields
ctx.owner.name.is(TraitSetterName) || ctx.owner.isStaticConstructor

Expand Down
8 changes: 8 additions & 0 deletions tests/neg/i15897.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
object O {
class AC(code: => Unit)

val action = new AC({mode = ???}) {} // error

def mode: AnyRef = ???
def mode=(em: AnyRef): Unit = {} // error // error // error
}
8 changes: 8 additions & 0 deletions tests/pos/i15897.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
object O {
class AC(code: => Unit)

val action = new AC({mode = ???}) {}

def mode: AnyRef = ???
def mode_=(em: AnyRef): Unit = {}
}