Fix #14168: Do not elide fields required for Scala.js interop semantics. #16187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
sjs-mandatory-fields
branch
3 times, most recently
from
ecf4e9f to
1b9b1cb
Compare
smarter
reviewed
Oct 18, 2022
| * the call site introduces an explicit `BoxedUnit.UNIT`. Even if the | ||
| * field has not been initialized at all (with `= _`), this results in | ||
| * an actual `()` value. | ||
| * In Scala 3, the same pattern returns `null`, as a `BoxedUnit`, so we |
There was a problem hiding this comment.
Could we instead change the behavior of Scala 3? We already have some logic for "unboxing" nulls from value classes: https://github.com/lampepfl/dotty/blob/3636ee6d0fda29daf9ef6e4e0491e2e504b227ed/compiler/src/dotty/tools/dotc/transform/Erasure.scala#L292-L317
There was a problem hiding this comment.
We cannot change it without breaking binary compatibility ;)
sjrd
force-pushed
the
sjs-mandatory-fields
branch
from
1b9b1cb to
49b7cda
Compare
smarter
approved these changes
Oct 18, 2022
|
Thanks, @sjrd for fixing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.