Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing comma Ident's span #20445

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

dwijnand
Copy link
Member

Fixes #16872

@dwijnand dwijnand force-pushed the trailing-commas-span branch 2 times, most recently from c3096e9 to ca687bc Compare May 21, 2024 16:45
@dwijnand dwijnand force-pushed the trailing-commas-span branch from ca687bc to 9b2f624 Compare May 21, 2024 16:57
@rochala
Copy link
Contributor

rochala commented May 21, 2024

I'm also adding a comment from the spree session:
image
Expression evaluation for value classes is actually working in metals, so the bug is in IntelliJ idea debugger implementation

@dwijnand dwijnand marked this pull request as ready for review July 1, 2024 09:02
@dwijnand dwijnand requested a review from odersky August 13, 2024 15:19
@dwijnand dwijnand merged commit 18af52a into scala:main Aug 14, 2024
19 checks passed
@dwijnand dwijnand deleted the trailing-commas-span branch August 14, 2024 12:06
WojciechMazur added a commit that referenced this pull request Aug 28, 2024
Backports #20445 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.5.2 milestone Oct 8, 2024
WojciechMazur added a commit that referenced this pull request Dec 4, 2024
Backports #20445 to the 3.3.5.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span includes trailing comma
5 participants