Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix declaring product of straight-to-jar compilation #20592

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Fix declaring product of straight-to-jar compilation #20592

merged 3 commits into from
Jun 26, 2024

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Jun 18, 2024

Currently the straight-to-JAR compilation does not declare any class file to Zinc, which prevents Zinc from compiling downstream modules incrementally.

For the context, we would like to enable straight-to-JAR compilation in sbt 2.x, and put remote caching on top of it.

@adpi2 adpi2 marked this pull request as ready for review June 19, 2024 11:35
@adpi2 adpi2 requested a review from bishabosha June 19, 2024 11:35
adpi2 added 2 commits June 19, 2024 16:42
@adpi2
Fix notify Zinc about class file in jar
6d7f782
@adpi2
Fix toString of JarArchive
2fb98fd 
It returns the absolute path of the jar file instead of '/'
@adpi2 adpi2 force-pushed the fix-inc-compilation-on-jar branch from 1f07142 to e0b7001 Compare June 19, 2024 14:42
@adpi2
Copy link
Member Author

adpi2 commented Jun 19, 2024

@jamie For a class file in a JAR, I returned the PlainFile as you suggested. Also I added a test.

@bishabosha
Copy link
Member

xsbt.ExtractUsedNamesSpecification has started failing - looks like there are classes not found?

@adpi2 adpi2 force-pushed the fix-inc-compilation-on-jar branch from e0b7001 to 8007626 Compare June 26, 2024 07:46
@adpi2
Copy link
Member Author

adpi2 commented Jun 26, 2024

xsbt.ExtractUsedNamesSpecification has started failing - looks like there are classes not found?

Fixed

@bishabosha bishabosha merged commit 41f1489 into scala:main Jun 26, 2024
24 checks passed
@adpi2
Copy link
Member Author

adpi2 commented Jun 27, 2024

@bishabosha What should I do to get this backported to 3.3.x?

@sjrd
Copy link
Member

sjrd commented Jun 27, 2024

Wait until the backporting bot gets to this PR. There's a lot of backlog but it's basically automated.

@adpi2 adpi2 mentioned this pull request Jun 27, 2024
Draft
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 10, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 11, 2024
@WojciechMazur
Backport "Fix declaring product of straight-to-jar compilation" to LTS (
be60505 
#21164)

Backports #20592 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@adpi2 @bishabosha @sjrd @Kordyjan