Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release .zip instead of .tar.gz for windows in sdkman #20630

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Release .zip instead of .tar.gz for windows in sdkman #20630

merged 3 commits into from
Jun 21, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Jun 19, 2024 •
edited
Loading

@hamzaremmal
Copy link
Member Author

I've just discussed with @marc0der about the presence of UNIVERSAL and we should remove it from the workflow

@hamzaremmal hamzaremmal marked this pull request as ready for review June 21, 2024 10:12
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jun 21, 2024
@hamzaremmal hamzaremmal enabled auto-merge June 21, 2024 10:17
marc0der
marc0der approved these changes Jun 21, 2024
View reviewed changes
Copy link

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hamzaremmal
Copy link
Member Author

Thanks @marc0der for taking the time to check the workflow !

@hamzaremmal hamzaremmal merged commit 5db826a into scala:main Jun 21, 2024
22 checks passed
@hamzaremmal hamzaremmal deleted the sdkman-windows-zip branch June 21, 2024 11:35
@WojciechMazur WojciechMazur added this to the 3.5.0 milestone Jul 1, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 1, 2024
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jul 1, 2024
WojciechMazur added a commit that referenced this pull request Jul 2, 2024
@WojciechMazur
Backport "Release .zip instead of .tar.gz for windows in sdkman" to 3…
3f8e3f5 
….5.0 (#20907)

Backports #20630 to Scala 3.5.0-RC3
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur WojciechMazur approved these changes

@marc0der marc0der marc0der approved these changes

Assignees

@WojciechMazur WojciechMazur

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hamzaremmal @marc0der @WojciechMazur