Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Only consider methods with 0 parameters in valueOf" to LTS #21153

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Backport "Only consider methods with 0 parameters in valueOf" to LTS #21153

merged 1 commit into from
Jul 10, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #20543 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@mbovel @WojciechMazur
Only consider methods with 0 parameters in valueOf (#20543)
3ff5115 
`valueOf` should only consider getters, which have 0 parameters.

test with:
```
scala3-compiler / testOnly dotty.tools.repl.ScriptedTests -- dotty.tools.repl.ScriptedTests.replTests
```

Fixes #19184
[Cherry-picked 4828244]
Base automatically changed from lts-20468 to lts-3.3 July 10, 2024 14:24
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-20902.

Reference

@WojciechMazur WojciechMazur merged commit d120926 into lts-3.3 Jul 10, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-20543 branch July 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @mbovel