Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit generatedNonLocalClass in backend when callback is not enabled #21186

Merged
merged 2 commits into from
Jul 16, 2024
Merged

emit generatedNonLocalClass in backend when callback is not enabled #21186

merged 2 commits into from
Jul 16, 2024

Conversation

bishabosha
Copy link
Member

fixes #21179

@bishabosha bishabosha marked this pull request as ready for review July 15, 2024 08:18
@Gedochao Gedochao added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jul 15, 2024
Gedochao
Gedochao reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a second opinion might be a good idea before we merge it.
Also, any chance we could add a test?

@Gedochao Gedochao requested a review from tgodzik July 15, 2024 08:31
tgodzik
tgodzik approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can say. Even if duplicated invocation of generatedNonLocalClass we should be good on the Bloop side as it's sets.

@bishabosha
Copy link
Member Author

I dont have time today for a test - but we had confirmation from IntelliJ that it should work

@bishabosha bishabosha enabled auto-merge July 16, 2024 17:47
@bishabosha bishabosha disabled auto-merge July 16, 2024 17:47
@bishabosha
Copy link
Member Author

I added the test @Gedochao @WojciechMazur

@WojciechMazur WojciechMazur merged commit bbb45ca into scala:main Jul 16, 2024
25 checks passed
@bishabosha bishabosha deleted the fix-non-local-class-reporting branch July 17, 2024 09:24
@WojciechMazur WojciechMazur mentioned this pull request Jul 17, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 17, 2024
@WojciechMazur
Backport "emit generatedNonLocalClass in backend when callback is not…
137be13 
… enabled" to 3.5.0 (#21209)

Backports #21186  to 3.5.0-RC5
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jul 17, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 17, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 19, 2024
@WojciechMazur
Backport "emit generatedNonLocalClass in backend when callback is not…
49f22bf 
… enabled" to 3.5.1 (#21210)

Backports #21186 to 3.5.1-RC2
@prolativ prolativ mentioned this pull request Nov 21, 2024
Merged
WojciechMazur added a commit that referenced this pull request Dec 2, 2024
@WojciechMazur
Backport "emit generatedNonLocalClass in backend when callback is not…
8e7690b 
… enabled" to LTS 3.3 (#21997)

Backports #21186 to the LTS 3.3 branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur WojciechMazur approved these changes

@Gedochao Gedochao Gedochao approved these changes

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scala 3.5.x stopped reporting generated classes via the Zinc incremental callback by default
4 participants
@bishabosha @tgodzik @Gedochao @WojciechMazur