Fix setup of CapSet arguments. #21309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natsukagami
reviewed
Aug 6, 2024
Comment on lines
+6
to
+8
| trait Source[+T, Cap^]: | ||
| final def await(using ac: Async^{Cap^}) = ac.await[T, Cap](this) // Contains[Cap, ac] is assured because {ac} <: Cap. | ||
|
|
There was a problem hiding this comment.
This wouldn't work if Async was declared extends caps.Capability
These arguments tell the whole truth; they cannot possibly be decorated with another capture set. So we should not add a capture set variable.
These need to be handled like reach capabilities. Fixes scala#21347
|
@Linyxus Ping for review. |
odersky
added a commit
that referenced
this pull request
Aug 10, 2024
- Cleanup all inferred types, not just result types of ValDefs and DefDefs. - To compensate, map overriding ValDefs and DefDefs to have declared result types. - Make type trees generated for varargs inferred. Based on #21309.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These arguments tell the whole truth; they cannot possibly be decorated with another capture set. So we should not add a capture set variable.