Handle suspension due to macro call in arbitrary phases #21651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
changed the title
Previously we only supported suspension in Typer and Inliner. In the added test case this happens in PostTyper, but I've seen it happen in Mixin too. Fixes scala#18517.
smarter
force-pushed
the
i18517
branch
2 times, most recently
from
9367900 to
bac8781
Compare
odersky
approved these changes
Sep 27, 2024
smarter
added
the
backport:nominated
WojciechMazur
removed
the
backport:nominated
hamzaremmal
added a commit
that referenced
this pull request
Nov 26, 2024
Related PR: #21651 There, a mechanism was added to the Phase classes, where any phase could catch a SuspendException and have a compilation unit suspended (stopped and recompiled later). In this fix, we rethrow incorrectly caught SuspendExceptions, so that the aforementioned mechanism can take care of the rest. Fixes: #21983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only supported suspension in Typer and Inliner. In the added test
case this happens in PostTyper, but I've seen it happen in Mixin too.
Fixes #18517.