Add support for clauseInterleaving in JVM generic signatures #21709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Oct 5, 2024
| // erased method parameters do not make it to the bytecode. | ||
| def effectiveParamInfoss(t: Type)(using Context): List[List[Type]] = t match { | ||
| case t: MethodType if t.hasErasedParams => | ||
| t.paramInfos.zip(t.erasedParams).collect{ case (i, false) => i } |
There was a problem hiding this comment.
I'm not sure why the previous code here didn't just use filter
sjrd
requested changes
Oct 7, 2024
tests/run/i21346.scala
Outdated
| // scalajs: --skip | ||
|
|
||
| object Foo: | ||
| def foo[X, Y, Z](x: X, y: Y)[A](z: Z) = ??? |
There was a problem hiding this comment.
We need to test what happens if we actually refer to A. And perhaps also give a result type since Nothing is a bit weird and not what we're testing for:
Suggested change
| def foo[X, Y, Z](x: X, y: Y)[A](z: Z) = ??? | |
| def foo[X, Y, Z](x: X, y: Y)[A](z: Z, A: A): (X, Y, Z, A) = ??? |
There was a problem hiding this comment.
Likewise, we should test what happens if the bounds of a type parameter are path-dependent on a previous term parameter.
It might not result in something very sensible, but it should be good enough not to crash Java reflection.
compiler/src/dotty/tools/dotc/transform/GenericSignatures.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/GenericSignatures.scala
Outdated
Show resolved
Hide resolved
sjrd
approved these changes
Oct 7, 2024
hamzaremmal
commented
Oct 7, 2024
tests/run/i21346.scala
Outdated
| def bar[X](x: X)[Y <: x.type](y: Y): (X, Y) = (x, y) | ||
|
|
||
| @main def Test = | ||
| val mtds = Foo.getClass().getDeclaredMethods().filterNot(_.getName() == "writeReplace") |
There was a problem hiding this comment.
The order of the methods is not deterministic, I'll order them alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21346