Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes type printing: take infix type modifier into account #21726

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

smarter
Copy link
Member

@smarter smarter commented Oct 8, 2024

This is similar to how the regular compiler .show handles infix but using explicit parens everywhere to not have to reimplement the precedence logic (maybe quote type printing should just use .show eventually).

This is similar to how the regular compiler `.show` handles `infix` but using
explicit parens everywhere to not have to reimplement the precedence
logic (maybe quote type printing should just use `.show` eventually).
@smarter smarter requested a review from jchyb October 8, 2024 09:21
Copy link
Contributor

@jchyb jchyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smarter smarter merged commit 35c7d74 into scala:main Oct 8, 2024
28 checks passed
@smarter smarter deleted the quotes-type-print branch October 8, 2024 12:04
@WojciechMazur WojciechMazur modified the milestones: 3.6.0, 3.6.3 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants