Drop inaccessible subclasses from refineUsingParent #21799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
approved these changes
Nov 5, 2024
hamzaremmal
reviewed
Nov 6, 2024
Comment on lines
+924
to
+928
| val inst = wildApprox(protoTp1) | ||
| if !inst.classSymbol.exists then | ||
| // E.g. i21790, can't instantiate S#CA as a subtype of O.A, because O.CA isn't accessible | ||
| NoType | ||
| else inst |
There was a problem hiding this comment.
@dwijnand The following change breaks the main branch by failling the tests/warn/i21860 test
This was referenced Nov 6, 2024
Closed
hamzaremmal
added a commit
that referenced
this pull request
Nov 7, 2024
Reverts #21799 The following changes were merged at the ~same time as adding the `tests/warn/i21860.scala` test, which are breaking that test. We revert it for now to unblock merging to `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21790