Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .msi artifacts to release assets #21834

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

WojciechMazur
Copy link
Contributor

We now include .msi files produced by build-msi-package in release assets including both .msi file and it's sha256

Resolves #21820

@hamzaremmal
Copy link
Member

We were waiting to get the code-signing certificate to implement this, but since we are not getting that soon, Core Team's decision was to include the .msiin the published artifacts with the corresponding .sha256

@WojciechMazur WojciechMazur merged commit 83c75dd into scala:main Nov 6, 2024
25 checks passed
@WojciechMazur WojciechMazur deleted the ci/release-include-msi branch November 6, 2024 12:23
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 6, 2024
WojciechMazur added a commit that referenced this pull request Nov 6, 2024
We now include .msi files produced by `build-msi-package` in release
assets including both .msi file and it's sha256

Resolves #21820
[Cherry-picked 83c75dd]
WojciechMazur added a commit that referenced this pull request Nov 8, 2024
Backports #21834 to the 3.6.2 branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Nov 8, 2024
@WojciechMazur WojciechMazur added this to the 3.6.2 milestone Nov 8, 2024
@tgodzik tgodzik added the release-notes Should be mentioned in the release notes label Nov 18, 2024
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this pull request Nov 20, 2024
We now include .msi files produced by `build-msi-package` in release
assets including both .msi file and it's sha256

Resolves scala#21820
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this pull request Nov 29, 2024
We now include .msi files produced by `build-msi-package` in release
assets including both .msi file and it's sha256

Resolves scala#21820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported. release-notes Should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include .msi files in the release assets
3 participants