Fix Java parsing of annotations on qualified types #21867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [scala#1][scala#1] this is valid syntax: java.lang.@nonnull String [scala#1]: https://checkerframework.org/jsr308/specification/java-annotation-design.html#qualified-type-syntax
|
🤯 I was just looking at scala/bug#9883 and didn't even get there yet. |
|
Happy to sign off on this fix, so at least it parses and the scala code can compile? |
|
I can't tell at a glance if the test tests something. Should I backport to scala 2 and complain if it doesn't? I just had lunch, so I have all afternoon PST to answer this question non-rhetorically. Edit: I guess you're saying scalac does parse that private signature, even if no one is holding a knife to its throat. |
som-snytt
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #1 this is valid syntax:
Fixes #21319