Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require organisation id in Annotation upload. #1155

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

markbader
Copy link
Contributor

@markbader markbader commented Aug 1, 2024

Description:

  • When uploading an Annotation(), an organisation_id is mandatory now. The organization_id might be provided directly within the Annotation() object, or it is inferred from current webknossos context.

Issues:

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog

@markbader markbader self-assigned this Aug 1, 2024
@markbader markbader marked this pull request as ready for review August 1, 2024 12:55
@normanrz
Copy link
Member

normanrz commented Aug 1, 2024

Not sure, I am happy with this. Providing an organization id might be cumbersome for users. And, I don't see why it wouldn't be possible to infer that upon upload.
Fwiw, we could even make the dataset name optional. It could be supplied upon upload.
cc @fm3

@markbader markbader changed the title Require organisation id in Annotation constructor. Require organisation id in Annotation upload. Jan 20, 2025
@markbader markbader requested a review from normanrz January 20, 2025 14:28
@markbader markbader enabled auto-merge (squash) January 20, 2025 14:44
@markbader markbader disabled auto-merge January 20, 2025 14:45
@markbader markbader merged commit b5a1d2c into master Jan 20, 2025
19 checks passed
@markbader markbader deleted the orga-id-in-annotation-constructor branch January 20, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload of wk.Annotation should require organization_id
2 participants