Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support renameable datasets and WK API v9 #1231

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Support renameable datasets and WK API v9 #1231

merged 9 commits into from
Jan 15, 2025

Conversation

markbader
Copy link
Contributor

@markbader markbader commented Dec 18, 2024 •
edited
Loading

Description:

  • Adds support for renameable datasets and the webknossos API version 9.

Issues:

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Added / Updated Tests

@markbader markbader self-assigned this Dec 18, 2024
@philippotto philippotto changed the title wk API v9 Support renameable datasets and WK API v9 Jan 8, 2025
@philippotto philippotto mentioned this pull request Jan 8, 2025
Open
7 tasks
@markbader markbader marked this pull request as ready for review January 9, 2025 15:09
@markbader markbader requested a review from normanrz January 9, 2025 15:14
normanrz
normanrz reviewed Jan 9, 2025
View reviewed changes
webknossos/Changelog.md Outdated Show resolved Hide resolved
webknossos/webknossos/administration/task.py Outdated Show resolved Hide resolved
webknossos/webknossos/client/api_client/datastore_api_client.py Show resolved Hide resolved
webknossos/webknossos/dataset/dataset.py Show resolved Hide resolved
webknossos/webknossos/dataset/dataset.py Outdated Show resolved Hide resolved
normanrz
normanrz approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍
For a next PR: Can you go through the API functions to see where we accept *_id arguments that could also take objects? For example, folder_path in Dataset.explore_and_add_remote or initial_team_ids in Dataset.announce_manual_upload

normanrz
normanrz reviewed Jan 15, 2025
View reviewed changes
webknossos/Changelog.md Outdated Show resolved Hide resolved
@markbader @normanrz
Update webknossos/Changelog.md
b48b0bc 
Co-authored-by: Norman Rzepka <[email protected]>
@markbader markbader merged commit 0efedee into master Jan 15, 2025
19 checks passed
@markbader markbader deleted the wk-api-v9 branch January 15, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@markbader markbader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for renamable datasets, API Version 9
2 participants
@markbader @normanrz