Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list_bounding_boxes() for zarr arrays #1238

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Add list_bounding_boxes() for zarr arrays #1238

merged 6 commits into from
Jan 23, 2025

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jan 22, 2025 •
edited
Loading

Description:

  • Add list_bounding_boxes() for zarr arrays, which improves speed for compress
  • Use zstd compression per default for zarr arrays

Todos:

  • Updated Changelog
  • Added / Updated Tests

@normanrz normanrz requested a review from markbader January 22, 2025 14:41
@normanrz normanrz self-assigned this Jan 22, 2025
markbader
markbader approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@markbader markbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

webknossos/webknossos/dataset/_array.py Outdated Show resolved Hide resolved
@normanrz normanrz enabled auto-merge (squash) January 23, 2025 16:04
@normanrz normanrz merged commit 49ccb52 into master Jan 23, 2025
19 checks passed
@normanrz normanrz deleted the zarr-list-bboxes branch January 23, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbader markbader markbader approved these changes

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normanrz @markbader