Make Zarr3 default and deprecations #1242
Open
+1,171
−5,464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibs into zarr3-default
normanrz
commented
Feb 5, 2025
| @@ -264,7 +264,7 @@ def download_and_unpack( | |||
|
|
|||
| BIOFORMATS_ARGS: list[tuple[str, str, dict, str, int, tuple[int, int, int], int]] = [ | |||
| ( | |||
| "https://samples.scif.io/wtembryo.zip", | |||
| "https://static.webknossos.org/data/wklibs-samples/wtembryo.zip", | |||
There was a problem hiding this comment.
Using mirrors of the testdata to avoid dependence on external servers.
philippotto
reviewed
Feb 7, 2025
| @@ -299,9 +241,8 @@ def _get_mag1_bbox( | |||
| def write( | |||
| self, | |||
| data: np.ndarray, | |||
| offset: Optional[Vec3IntLike] = None, # deprecated, relative, in current mag | |||
| json_update_allowed: bool = True, | |||
There was a problem hiding this comment.
why doesn't the View.write method have a allow_resize parameter (only MagView.write has it currently)?
There was a problem hiding this comment.
See my comment above. A View doesn't have a reference to its Layer, so it cannot resize the Layer.
Co-authored-by: Philipp Otto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
allow_resizeandallow_unalignedargument to make it more robust against accidental concurrency issuesIssues:
Todos:
allow_resizebehaviorallow_unalignedargfrom_imagesfor unexpected bboxesMake sure to delete unnecessary points or to check all before merging: