Fix recent regressions not allowing Metals to pass its tests #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look into the DAP changes and if need to adjust anything. Looks the CI here is failing? |
Previously, if `--best-effort` option was set, every project would be compiled in the best effort mode, including those using scala 2.
jchyb
commented
Jul 4, 2024
| @@ -337,7 +337,7 @@ object TestTask { | |||
| taskDefs.map { | |||
| case TaskDefWithFramework(taskDef, _) => | |||
| selectedTests.get(taskDef.fullyQualifiedName()) match { | |||
| case None => | |||
| case None | Some(Nil) => | |||
There was a problem hiding this comment.
This fixes the DebugProtocolSuite tests (previously it was
selectedTests.get(taskDef.fullyQualifiedName()).getOrElse(Nil) match {
case Nil =>
case selectedTests =>and I think the Some(Nil) got lost in the refactor)
|
I removed some leftover logs, hopefully that should help with the CI tests here (no idea why they broke) |
jchyb
changed the title
|
Ready for review! This should fix all of the tests in metals from https://github.com/scalameta/metals/actions/runs/9760409386/job/26939422405?pr=5219 outside of MillServerCodeLensSuite in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
--best-effortoption was set, every project would be compiled in the best effort mode, including those using scala 2. This first commit fixes theCodeLensLspSuitetest.DebugProtocolSuitemight have been broken by 7154823 (before that merge it works),but I am still investigating that (or maybe the broken metals test should change?)