Persist sbt metadata in project model #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
force-pushed
the
topic/sbt-build-extraction
branch
2 times, most recently
from
05f37e2 to
b33640d
Compare
jvican
force-pushed
the
topic/sbt-build-extraction
branch
from
b33640d to
aa3374b
Compare
Add the sbt metadata field in the project configuration file so that we can present it to IDEs via BSP. A nice property of the approach taken in this PR is that we automatically create a project file for the build under the meta build `.bloop` directory. This is helpful for two reasons: 1. Bloop can compile your build just as it can compile your project. 2. Bloop knows immediately any change that happens to your build. The implementation here proposed is quite tricky because of some sbt implementation details. We cannot get the `autoImports` from the build of the build, so we need to roll out our own piece of code to do so with the `pluginData` of the meta build. This repeats some work because it needs to classload the build data for our project's build, but it's negligible in terms of time spent (<500 ms in the cases I've tested). Aside from implementing this feature, this commit also removes any cross published module and instead creates a static module for it. This helps development because we can compile the projects for 0.13 and 1.0 immediately without needing to use `+` and `^`, which are completely broken in our build.
jvican
force-pushed
the
topic/sbt-build-extraction
branch
from
aa3374b to
ecd5a8b
Compare
|
The last commit adds a fancier |
Adds support to elide `discoveredSbtPlugins` for all sbt versions if either `bloopInstall` or `bloopGenerate` are under execution. This makes the process faster (exporting the bloop build takes now 11 seconds!).
jvican
force-pushed
the
topic/sbt-build-extraction
branch
from
58e69e6 to
cad72a1
Compare
Duhemm
approved these changes
Jun 13, 2018
| @@ -1,5 +1,6 @@ | |||
| import java.nio.file.{Files, Path} | |||
|
|
|||
| val BloopClassifiers = Set("sources", "javadoc") | |||
There was a problem hiding this comment.
Nope, just removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the sbt metadata field in the project configuration file so that we
can present it to IDEs via BSP. A nice property of the approach taken in
this PR is that we automatically create a project file for the build
under the meta build
.bloopdirectory. This is helpful for tworeasons:
The implementation here proposed is quite tricky because of some sbt
implementation details. We cannot get the
autoImportsfrom the buildof the build, so we need to roll out our own piece of code to do so with
the
pluginDataof the meta build. This repeats some work because itneeds to classload the build data for our project's build, but it's
negligible in terms of time spent (<500 ms in the cases I've tested).
And it does reuse the parent classloader from the meta build.
Aside from implementing this feature, this commit also removes any cross
published module and instead creates a static module for it. This helps
development because we can compile the projects for 0.13 and 1.0
immediately without needing to use
+and^, which are completelybroken in our build.