Add the possibility to disable color #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No Color users add support
olafurpg
reviewed
Jun 19, 2018
| @@ -14,6 +14,8 @@ case class CliOptions( | |||
| version: Boolean = false, | |||
| @HelpMessage("If set, print out debugging information to stderr.") | |||
| verbose: Boolean = false, | |||
| @HelpMessage("If set, do not color output.") | |||
| noColor: Boolean = false, | |||
There was a problem hiding this comment.
Would it be better to respect the environment variable NO_COLOR? http://no-color.org/
There was a problem hiding this comment.
Indeed, this would be a great default. I'll commit a message adding it so that we can unblock this pull request next week.
jvican
added
enhancement
cli
ergonomics
|
Added bloop to the list of software that now supports |
jvican
approved these changes
Jul 3, 2018
|
Great job @shamsak58 🎉 Thank you for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Color users add support