Watch changes in single files #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does three things: 1. Updates to another version of directory-watcher that exposes an internal method. We use this internal method to fix the linked ticket; Bloop now watches the parent directories of source files in a non-recursive way. 2. Re-engineers the tests for file watching using the Task APIs and making it easier to test. 3. Adds a new test to make sure that #598 is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does three things:
internal method. We use this internal method to fix the linked
ticket; Bloop now watches the parent directories of source files in a
non-recursive way.
making it easier to test.