-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean all projects by default #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @tues 😄
CI is failing with:
[error] /drone/src/github.com/scalacenter/bloop/frontend/src/test/scala/bloop/tasks/CleanTaskSpec.scala:3:8: object Project is not a member of package bloop
[error] import bloop.{Compiler, Project}
[error] ^
[error] /drone/src/github.com/scalacenter/bloop/frontend/src/test/scala/bloop/tasks/CleanTaskSpec.scala:21:6: not found: type Project
[error] ): Project =
[error] ^
[error] two errors found
Yeah, I'm not sure what's wrong with that. I can clearly see |
The issue is likely that you have not rebased on top of the latest master? I merged recently #653 which moves |
If `bloop clean` is invoked without any projects specified, clean all projects (this is how it used to work). Also fix the command help and documentation. Closes scalacenter#593.
🤦♂️ Sorry, I must've forgotten to rebase it indeed. Thanks. Also I've just realised that the builds which succeeded seem to be disabled so I shouldn't take them into account. |
Yes, the CI will only really build either the last commit of your PR or any future commit in an open PR. Previous commits are not run because they were submitted to the repo before a PR is open. We do this to save resources. |
I mean Anyway, |
We're experiencing some spurious failures in the Windows CI lately. Feel free to restart the build if it happens again (I just did, looking forward to merging this). |
Looks like I've fixed the root of our spurious CI failures, so they shouldn't happen again in the future 😉 I'll be merging this as soon as I've got green light. |
Thanks 🙂 I'm afraid I lack permissions to restart builds, though, unless you're talking about artificially amending some commit to trick CI into rebuilding automatically. |
Also add
CleanTaskSpec
, fix documentation and remove some unused variables/parameters.Closes #593.