Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean all projects by default #655

Merged
merged 3 commits into from
Sep 23, 2018
Merged

Clean all projects by default #655

merged 3 commits into from
Sep 23, 2018

Conversation

tues
Copy link
Contributor

@tues tues commented Sep 22, 2018

Also add CleanTaskSpec, fix documentation and remove some unused variables/parameters.

Closes #593.

@tues tues added docs cli ergonomics Any change that affects developer ergonomics and the easiness of use of bloop. labels Sep 22, 2018
Copy link
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tues 😄

CI is failing with:

[error] /drone/src/github.com/scalacenter/bloop/frontend/src/test/scala/bloop/tasks/CleanTaskSpec.scala:3:8: object Project is not a member of package bloop
[error] import bloop.{Compiler, Project}
[error]        ^
[error] /drone/src/github.com/scalacenter/bloop/frontend/src/test/scala/bloop/tasks/CleanTaskSpec.scala:21:6: not found: type Project
[error]   ): Project =
[error]      ^
[error] two errors found

@tues
Copy link
Contributor Author

tues commented Sep 23, 2018

Yeah, I'm not sure what's wrong with that. I can clearly see frontend/src/main/scala/bloop/Project.scala file in the repo, there's a final case class Project inside, and it compiles and works fine on my machine. Also passed some of the CI builds. Really weird 🤔

@jvican
Copy link
Contributor

jvican commented Sep 23, 2018

The issue is likely that you have not rebased on top of the latest master? I merged recently #653 which moves Project around.

If `bloop clean` is invoked without any projects specified, clean all
projects (this is how it used to work).

Also fix the command help and documentation.

Closes scalacenter#593.
@tues
Copy link
Contributor Author

tues commented Sep 23, 2018

🤦‍♂️ Sorry, I must've forgotten to rebase it indeed. Thanks. Also I've just realised that the builds which succeeded seem to be disabled so I shouldn't take them into account.

@jvican
Copy link
Contributor

jvican commented Sep 23, 2018

Yes, the CI will only really build either the last commit of your PR or any future commit in an open PR. Previous commits are not run because they were submitted to the repo before a PR is open. We do this to save resources.

@tues
Copy link
Contributor Author

tues commented Sep 23, 2018

I mean windows extra and windows community-build always succeed because they don't seem to do anything - I didn't notice it at first and thought that some builds failed and some passed, so it must be random failure.

Anyway, windows basic failed again, but this time it doesn't look like my fault 😉

@jvican
Copy link
Contributor

jvican commented Sep 23, 2018

We're experiencing some spurious failures in the Windows CI lately. Feel free to restart the build if it happens again (I just did, looking forward to merging this).

@jvican
Copy link
Contributor

jvican commented Sep 23, 2018

Looks like I've fixed the root of our spurious CI failures, so they shouldn't happen again in the future 😉 I'll be merging this as soon as I've got green light.

@jvican jvican merged commit c7a281f into scalacenter:master Sep 23, 2018
@tues
Copy link
Contributor Author

tues commented Sep 23, 2018

Thanks 🙂 I'm afraid I lack permissions to restart builds, though, unless you're talking about artificially amending some commit to trick CI into rebuilding automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli docs ergonomics Any change that affects developer ergonomics and the easiness of use of bloop.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redefine the semantics of clean without arguments
2 participants