Apply system properties to all test framworks #664
Conversation
|
|
||
| val cls = frameworks.map(f => f.getClass.getName) | ||
|
|
||
| if(sysProperties.isEmpty) |
There was a problem hiding this comment.
I propose we add the logger.warn from above in this part of the if expression so that the logic is clearer to follow (we can assume frameworkSpecificRawArgs.nonEmpty == true always, which makes ignoredArgs.nonEmpty == sysProperties.isEmpty. Also, let's move cls to the block of else to avoid computing it the arguments are only system properties.
There was a problem hiding this comment.
if user pass in both system properties and test framework specific args, ignoredArgs.nonEmpty and sysProperties.isEmpty won't be the same tho...if we move warn inside sysProperties.isEmpty block, some test framework specific args will just be ignored silently right?
There was a problem hiding this comment.
Ohhh, I see what you wanted to see here. I apologize for my confusing comment. I'll submit another PR with this change plus an error message if the user passes both system properties and ignored args.
jvican
added
bug
jvican
changed the title
|
LGTM, I'll merge as soon as CI is green, thank you again! |
Fixes #662