Use bsp 1.0.0 and implements its new methods #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite tests the `utestJVM-test` test suite.
jvican
added
build server
jvican
changed the title
jvican
changed the title
The implementation of run comes from `Interpreter.run` and is adapted for the use of BSP.
jvican
force-pushed
the
topic/bsp-1.0.0
branch
from
40d6c8d to
23282ba
Compare
|
It would be great to implement |
|
I think I'm merging this to keep master synced with the latest changes. I'll follow up on the rest of missing items in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades to 1.0.0 to implements its new methods, which we didn't implement because Intellij didn't implement us yet. However, as they start to be implemented in IntelliJ and other clients, we add the implementations so that the existing clients, like IntelliJ or Metals, can start benefiting from them.
We miss the following items to be fully implementing BSP 1.0.0:
buildTarget/testbuildTarget/runbuildTarget/scalaTestClassesbuildTarget/scalaMainClassesAlongside these missing items, I'd like to implement request buffering in bloop so that the clients can indiscriminately send request without taking into account whether they finished or not. I suspect this is not going to be easy.
I'm not sure yet how I'm going to organize my work to implement the missing entrypoints, but it's likely I will not do everything in this PR. I'm mostly trying to prioritize for the most important things.