Allow reflective bloop invocation with cancellation #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
added
the
build server
olafurpg
reviewed
Oct 18, 2018
| out: PrintStream, | ||
| err: PrintStream, | ||
| props: java.util.Properties, | ||
| cancel: CompletableFuture[Boolean] |
There was a problem hiding this comment.
Can we make this java.lang.Boolean?
There was a problem hiding this comment.
Boxed scala.Boolean has a different signature
➜ target git:(bsp) ✗ scalac foo.scala && javap a$ // with List[scala.Boolean]
Compiled from "foo.scala"
public final class a$ {
public static a$ MODULE$;
public static {};
public void b(scala.collection.immutable.List<java.lang.Object>);
}
➜ target git:(bsp) ✗ scalac foo.scala && javap a$ // with List[java.lang.Boolean]
Compiled from "foo.scala"
public final class a$ {
public static a$ MODULE$;
public static {};
public void b(scala.collection.immutable.List<java.lang.Boolean>);
1. Add a `reflectMain` method that exposes a Java-only API to run Bloop's CLI (usually for executing a long-running process like `bloop bsp`). 2. Add support for cancellation. Whenever the user feels like quitting, it can complete the `cancel: CompletableFuture[Boolean]` with a `true` to force the cancellation. If it completes it with a `false`, the cancellation will not happen.
jvican
force-pushed
the
topic/reflective-main
branch
from
8751ecd to
ed7b7a5
Compare
|
Thanks for the catch, let's get this change ready in a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflectMainmethod that exposes a Java-only API to runBloop's CLI (usually for executing a long-running process like
bloop bsp).it can complete the
cancel: CompletableFuture[Boolean]with atrueto force the cancellation. If it completes it with a
false, thecancellation will not happen.