Don't fail in builds of single sbt plugins #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I knew about the possibility of failing in builds of single sbt plugins, but however didn't protect us about them because I hoped sbt would expose an entrypoint to know for real if a project is a meta build or not. As this hasn't been the case, I've implemented a simple heuristic to know whether a build is a meta-project or not: check if the CWD is the same as the root of the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I knew about the possibility of failing in builds of single sbt plugins,
but however didn't protect us against them because I hoped sbt would
expose an entry point to know for real if a project is a meta build or
not. As this hasn't been the case, I've implemented a simple heuristic
to know whether a build is a meta-project or not: check if the cwd is
the same as the root of the build.
Kudos to @olafurpg for finding this bug in sbt-scalafix.