Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#698 - Support proxy in coursier instalation #699

Merged
merged 1 commit into from
Nov 6, 2018
Merged

#698 - Support proxy in coursier instalation #699

merged 1 commit into from
Nov 6, 2018

Conversation

crakjie
Copy link

@crakjie crakjie commented Nov 6, 2018 •
edited
Loading

I'm not a python developer, I hope it's not too much outside of pythons standards.
The openurl lib from python can already read http_proxy and https_proxy so nothing is needed there.

@crakjie
Copy link
Author

crakjie commented Nov 6, 2018 •
edited
Loading

I put the proxy in both case is_local and !is_local.

jvican
jvican approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you! Have you tried it locally? I’m merging it now assuming that you have

@jvican jvican merged commit 83a3df8 into scalacenter:master Nov 6, 2018
@crakjie
Copy link
Author

crakjie commented Nov 7, 2018

Yes, I have to test, to be able to install bloop.
I tried with and without environment variable, to be sure people without theses env var are not block either.

@jvican jvican mentioned this pull request Nov 7, 2018
Closed
@jvican jvican mentioned this pull request Nov 22, 2018
Closed
@jvican jvican added build server Any issue or pull request that has to do with hot compilers or BSP. feature labels Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvican jvican jvican approved these changes

Assignees
No one assigned
Labels
build server Any issue or pull request that has to do with hot compilers or BSP. feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crakjie @jvican