Set jvm proxy from client environment variables #713
Conversation
crakjie
force-pushed
the
set-jvm-proxy#698
branch
from
37913e8 to
3d64431
Compare
There was a problem hiding this comment.
Hey @crakjie, I've left a few comments regarding the policy of modifying environment variables globally. Aside from this, it looks good 👍 Could we also add a detailed explanation in the FAQ (https://scalacenter.github.io/bloop/faq/) of our website so that people know how our proxy support works? I would explain users the following two possibilities to use their proxys with bloop:
- Run the server with environment variables (if they can).
- Otherwise, tell how the mechanism to pick up environment variables from clients work via Nailgun.
jvican
added
bug
jvican
changed the title
|
@crakjie I'm waiting for your changes here 😄 Whenever you have them ready, push them (make sure you rebase on latest master too) and I merge them. |
crakjie
force-pushed
the
set-jvm-proxy#698
branch
2 times, most recently
from
f950c0b to
aafa51b
Compare
|
I had updated MR to follow recomendation and rebase with upstream (as of 26/11/2018). |
|
@crakjie Thanks for your work Etienne. I had to change quite a big part of your PR after I had a closer look at the best way of deal with proxy settings. I've added scaladocs and improved the FAQ entry to reflect what the current configuration requirements are. Please have a look and let me know if this works for you (this approach is more conservative but i think covers most of the use cases reasonably well while reducing the danger that things go wrong in non-reproducible ways). |
jvican
force-pushed
the
set-jvm-proxy#698
branch
from
07591f7 to
b8f22e9
Compare
And switch to https instead of git for the submodules. Fixes scalacenter#698.
Make several changes in the code to add a new policy for the way we handle proxy settings in bloop. This new policy hopes to reduce proxy configuration problems in different clients that run in different environments in the same machine.
We seem to get some spurious errors in CI after some changes in latest master. These errors look related to caching the test resources. With this commit, the user can add `FORCE_TEST_RESOURCES_GENERATION` to the commit message and the CI will force the generation of the test resources.
jvican
force-pushed
the
set-jvm-proxy#698
branch
from
b8f22e9 to
eaad906
Compare
The test
detectsMacrosInClasspathwich call directlych.epfl.scalacurrently not work under a proxy.Except that all other
frontend/testis working.I had initially called the proxy setting function in the
runfunction but this function is bypass by the tests which by the way need proxy too.