Allow to run externally-defined main classes #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the following error is triggered when specifying a valid class that is not defined in the project: ```shell $ bloop run root -m play.core.server.ProdServerStart [E] Missing main class in project 'root' ``` Simplify the logic of `findMainClasses()`. The validation logic is redundant since specifying an invalid main class will be caught at a later point: ```shell $ bloop run root -m test [E] Error: Could not find or load main class test ```
tindzk
force-pushed
the
issue/716-external-main-classes
branch
from
6f5e937 to
9b1579c
Compare
|
I merged this too quick, @tindzk would you mind following up this bug fix with a test? The logic is straightforward but every bug fix should have a test to ensure that we don't regress. |
jvican
added
the
community
jvican
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following error is triggered when specifying a valid
class that is not defined in the project:
Simplify the logic of
findMainClasses(). The validation logic isredundant since specifying an invalid main class will be caught at a
later point: