Propagate main class in sbt plugin #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
changed the title
jvican
added
enhancement
task / run
community
|
@tindzk It looks like this change is making the CI hang on Windows, so I had to kill the process manually. |
Scala.js link for a test module would fail in the presence of a main class in the configuration file of the test project, because it would force the link infrastructure to set up main module initializers instead of test module initializers.
jvican
force-pushed
the
issue/718
branch
3 times, most recently
from
f5ffb6f to
35791e3
Compare
In sbt, we cannot reuse `mainClass` because it triggers compilation when the user has not specified it in its build.sbt. From the outside, there is no way for us to know if the user declared it or not, and therefore we plainly cannot trigger the execution of `mainClass`. To allow users to specify the main class though, we introduce a `bloopMainClass`, a duplicate of `mainClass` which doesn't trigger compilation, so that users that don't want to verbosely pass in the main class every time their application can set it in their build.sbt file.
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #718.