Implement test autocompletion for bash/zsh/fish #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
force-pushed
the
test-autocompletion
branch
2 times, most recently
from
26cdfa9 to
8deccc2
Compare
tanishiking
commented
Dec 5, 2018
| @@ -275,10 +275,13 @@ object Interpreter { | |||
| completion <- cmd.format.showMainName(main) | |||
| } state.logger.info(completion) | |||
| case Mode.TestsFQCN => | |||
| import ExecutionContext.scheduler | |||
There was a problem hiding this comment.
I'm not sure which scheduler should we use here...
tanishiking
force-pushed
the
test-autocompletion
branch
4 times, most recently
from
801f800 to
a7f257e
Compare
|
Nice! @tanishiking Will have a look at this next Monday since i'm in vacation for some days, thanks for the new tests 😄 |
…ject <project>` This commit enable bloop to return testsFQCN in a project using `bloop autocomplete --format <shell> --mode testsfqcn --project <project>`. scalacenter#426
We reuse the scheduler that the interpreter runs instead of hardcoding it in the autocompletions engine. Besides, this commit makes some stylistic changes to the code.
jvican
force-pushed
the
test-autocompletion
branch
from
a7f257e to
83af9ca
Compare
jvican
added
enhancement
cli
ergonomics
jvican
approved these changes
Dec 27, 2018
There was a problem hiding this comment.
@tanishiking Thank you 🙏 I'm sorry for the delay in this PR, I removed the hardcoded ExecutionContext.scheduler by turning everything into a task and letting the scheduler of the interpreter be the one running the autocompletion task. The rest of the PR LGTM! 😄 This enhancement will be available in the upcoming 1.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
bloop autocomplete --format <shell> --mode testsfqcn --project <project>bloop test <project> --onlyHere are demos
zsh
(in this video, autocompletion transformed the command from
blooptoblobloop, but this is not actually happening..., I think this is a problem ofasciinemaand my zsh configuration...)bash
fish