Fix installation bugs and add Windows installation #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds both the `bloop.cmd` for normal CMD users and a scoop installer for Powershell users. Fixes #567
1. Persist the choice of build tool and package manager so long as the tab is not closed. 1. Make links work (a page linking to #nix) will click the nix button when loading the page. Useful when linking to docs from external places.
jvican
added
enhancement
install
ergonomics
|
/cc @philwalk @andrezimmermann @Katrix on improvements to Windows. /cc @igor-ramazanov @ouchxp @countfloyd @gabro on the fix of |
gabro
reviewed
Dec 10, 2018
| @@ -31,3 +31,4 @@ website/build/ | |||
| website/build/bloop-gh-pages/ | |||
| node_modules/ | |||
| package-lock.json | |||
| .metals/ | |||
| @@ -34,6 +34,12 @@ | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| previouslyBuildActive = null; | |||
| if (typeof(Storage) !== "undefined") { | |||
There was a problem hiding this comment.
Unrelated to this PR specifically, but typeof is an operator and it doesn't need parenthesis.
It works anyway because (a) == a, but it caught my JS dev eye 😅
There was a problem hiding this comment.
👍 thanks, good to know, will leave it as is to prove how terrible a js developer am, i cargo-culted it from https://www.w3schools.com/html/html5_webstorage.asp
There was a problem hiding this comment.
|
I'm merging, the Windows CI error seems spurious and this doesn't change the main logic of the server anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the session storage.
The fixed tickets are linked in the commit messages.