Fix scalaInstanceFromBloop in boostrapped server
#774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When coursier bootstraps bloop, the code source location for the classes has an unknown scheme that trips the creation of the scala instance. This error only happens when coursier boostraps, as it inlines all jars in a jar file that is inlined in a shell script, and there's no notion of independent jars we can use to instantiate a scala instance. To fix this problem, we detect this error and add a fallback mechanism where: 1. We get the scheme specific part and read the content stream. 2. Copy the content stream to an independent file that we then use to instantiate an scala instance. We don't add tests for this improvement because it's a rare error enough that would need a lot of test instrumentation to test reliably. Local testing confirms that compiling java only projects with no scala instance defined works now in systems where bloop is boostrapped.
|
Reported by @Arthurm1 in Gitter https://gitter.im/scalacenter/bloop?at=5c20eb9e6649aa1f82c3cf1d, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When coursier bootstraps bloop, the code source location for the classes
has an unknown scheme that trips the creation of the scala instance.
This error only happens when coursier boostraps, as it inlines all jars
in a zip that is then inlined in a shell script; there's no notion of
independent jars we can use to instantiate a scala instance. To fix
this problem, we detect this error and add a fallback mechanism where:
instantiate an scala instance.
We don't add tests for this improvement because it's a rare error enough
that would need a lot of test instrumentation to test reliably. Local
testing confirms that compiling java only projects with no scala
instance defined works now in systems where bloop is boostrapped.