Upgrade launcher tests to 1.2.0 #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
added
bug
jvican
force-pushed
the
topic/launcher-1.2.0
branch
from
3b5e9af to
936c359
Compare
And fix error in logic checking for compatible bloop version.
This error has already been updated in the 1.2.0 installation scripts.
For some reason, the coursier-1.1.0-M8 jars have misteriously disappeared from Maven Central: https://repo1.maven.org/maven2/io/get-coursier/coursier_2.12/1.1.0-M8/ Unfortunately, this error happens when resolving bloop-launcher 1.2.0... so we keep it as it was before, we upgrade to 1.1.0-M9 in 1.2.1 and then we will upgrade the version of our tests. I confirm that all tests pass locally except the one caused by the spurious coursier error.
jvican
force-pushed
the
topic/launcher-1.2.0
branch
from
936c359 to
d2b934f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix error in logic checking for compatible bloop version.