Include resources in dependency classpath #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #730, I claimed: > Resources are files that are used at runtime, either when testing or running an application. These files can be generated by the build tool or be present in a resource directory of a project. However, this was not the full story, it turns out that resources are also required by macros, which happen at compile time, and therefore resources are required by `compile`. This patch modifies bloop to use the classpath with resources as the default from now on for any action in bloop, as all of them require it. Fixes #763
Test fails in Windows because in Windows the resources directories are not created. We create them so that they show up in the full dependency classpath as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #730, I claimed:
However, this was not the full story, it turns out that resources are also
required by macros, which happen at compile time, and therefore resources
are required by
compile.This patch modifies bloop to use the classpath with resources as the
default from now on for any action in bloop, as all of them require it.
Fixes #763