Disable warnings logged by nuprocess library #798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running launcher and
bloop
is not on thePATH
we get the following error:NuProcess library is using a logger, which always logs warning when it cannot start, but since
bloop
is reading the result of the command from theexit code
, I am wondering how this (small, but annoying) issue could be addressed? Please, suggest/discuss better solution if you have one.This PR is a simplest fix I could come up with: disabling warnings from
NuProcess
(the impact analysis is at the end of this message). It gives us more clear output:Analysis:
NuProcess
is inconsistent... most of the time it just swallows the exception, but in three cases it also logs warnings, before doing nothing...Those warnings are logged when exception happens while:
a) reading stdout/stderr
b) starting process
c) creating pipes - but this cases does not affect
launcher
, since the exception is actually propagated after being loggedI believe both a) and b) are of low impact, since
launcher
depends on exit codes anyway