Update sbt and coursier #1090
Update sbt and coursier #1090
Conversation
|
Missed some relevant stuff. Looking into it. |
ckipp01
force-pushed
the
sbt
branch
3 times, most recently
from
4f17afc to
887cbea
Compare
|
I'll need to spend some more time on this 🤔 ... I continually get the following If found some information about how forking or other things can help, but nothing has seemed to work yet. |
| @@ -82,7 +82,7 @@ class ScalafixImplSuite extends FunSuite with DiffAssertions { | |||
| } | |||
|
|
|||
| test("error") { | |||
| val cl = new URLClassLoader(Array()) | |||
| val cl = new URLClassLoader(Array(), null) | |||
There was a problem hiding this comment.
Ahhh, I tried the fork := true up above like you did, but didn't catch this one down here.
There was a problem hiding this comment.
It was also necessary to update baseDirectory.in(Test) := baseDirectory.in(ThisBuild).value. That should honestly be the default behavior in sbt, but changing the default would break a lot of builds
|
Thank you for this contribution! It wasn't at all obvious what was causing those errors. The Scalafix test suite previously relied on both
The last commit enables forking and fixes the build to use a correct working directory as well as fixes a test that was written in a fragile way. |
The Scalafix test suite uses `this.getClass.getClassLoader` to lookup symbols from scala-library.jar. In sbt v1.3.x, the default classloader layering strategy changed so that `this.getClass.getClassLoader` only contains Scalafix-defined classes, with classes from dependency classes coming from a parent classloader. This commit makes the tests pass on sbt v1.3.x by enabling forking so that `this.getClass.getClassLoader` is always a flat classloader containing all classes.
This pr updates sbt from 1.2.8 to 1.3.9. Tests all seemed to pass locally as well as publishing locally. Since we were using an sbt version prior to 1.3.x, I'm assuming that's why we were explicitly using
coursier-sbt. I therefore removed that dependency on the plugin.Supercedes #1085