Fix #1104

[giabao]

Fix #1104

[olafurpg]

Thank you for this contribution! Is there a relationship between this change and scalameta/scalameta#2043 ?

[ohze]

Given:

0 trait SymbolTest {
1   def shouldBe(right: Any)
2   def arg = 1
3   this shouldBe (arg)
4 }               ↑   ↑
                 16   21

We use textDocument.occurrences produced by semanticdb-scalac to get symbols (String, eg (arg)) from a Range/ Position (eg, [3:16..3.21))

To workaround for scalameta/scalameta#1083, when get Position for name (arg), instead of returning [3:16..3.21), we return [3:17..3.20) and use that Position to lookup symbols from occurrences.

But in textDocument.occurrences produced by semanticdb-scalac, there is only SymbolOccurrence(range = [3:16..3.21), symbol = "(arg)") (have no Occurrence with range == [3:17..3.20)). So the lookup will return None.

Code changes in this PR: Only re-try getting symbol from range [3:16..3.21) when workingaround scalameta/scalameta#1083.

[ohze]

Is there a relationship between this change and scalameta/scalameta#2043 ?

No. The bug resolved in this PR have no relation to implicit conversion as in scalameta/scalameta#2043.

Given:

trait AnyShouldWrapper {
  def shouldBe(right: Any)
}
trait SymbolTest {
  implicit def convert(o: Any)(implicit foo: Int): AnyShouldWrapper
  implicit val foo: Int = 1
  def arg = 1
  this shouldBe (arg)
}

In the last statement this shouldBe (arg):

• This PR: Getting symbol for name (arg) return Some(symbol), not None.
• Fix #2040 Lost SymbolOccurrence info when produce semanticdb for implicit conversion with implicit params scalameta/scalameta#2043: Getting symbol for this return something like SymbolTest#this()., not SymbolTest#convertToAnyShouldWrapper().

[olafurpg]

LGTM 👍 Thank you for explaining!

[olafurpg]

Please let me know if you're blocked by this fixed and need a new release. I would prefer to wait a bit longer to cut a new release since it always takes a while to synchronize scalafix-core/sbt-scalafix