RemoveUnused: document 2.13.2 -Wconf to keep -Xfatal-warnings
#1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it's impossible to demonstrate that, as the testkit currently requires the test input project and the overall Scalafix build to have the same scala version.
bjaglin
commented
May 7, 2020
| Unfortunately, it's not possible exclude unused imports from -Xfatal-warnings. | ||
| compiler warnings do not fail the build before running Scalafix. If you are | ||
| running 2.13.2 or later, you may keep `-Xfatal-warnings` by modifying how | ||
| specific warnings are handled via `scalacOptions += "-Wconf:cat=unused:info"`. |
There was a problem hiding this comment.
I also tried
Suggested change
| specific warnings are handled via `scalacOptions += "-Wconf:cat=unused:info"`. | |
| specific warnings are handled via `scalacOptions += "-Wconf:cat=unused:silent"`. |
but it does what you can expect: the diagnostic is gone!
There was a problem hiding this comment.
Interesting, I suppose that makes sense! The info messages are anyways a good reminder that you have unused imports that can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have successfully used scala/scala#8373 on my build to keep/relax
-Xfatal-warnings, and delegate unused imports fix/enforcement from scalac to scalafix.The only impact of
-Wconf:cat=unused:infoon semanticdb-scalac 4.3.10 seems to be theseverityattribute, so the rule works as-is.