force usage of shaded TPrint #1546
Conversation
bjaglin
force-pushed
the
fix-pprint
branch
4 times, most recently
from
b23114d to
e65c659
Compare
| "testPath" -> testPath, | ||
| "semanticdbPath" -> semanticdbPath | ||
| ) | ||
| pprint.PPrinter.BlackWhite.tokenize(map).mkString |
There was a problem hiding this comment.
Only pprint.TPrint has been shaded into metaconfig. I felt like other usages of pprint here and below were not worth adding an explicit compile-time dependency to pprint
| import scalafix.config.CustomMessage | ||
|
|
||
| class TPrintImplicits { | ||
| implicit val tprintPattern: TPrint[List[CustomMessage[Pattern]]] = |
There was a problem hiding this comment.
This implicit has actually no effect (neither before or after this PR) as the signature of the param it was targeting changed in https://github.com/scalacenter/scalafix/pull/907/files#diff-fa445c2f97a1bfb229caa4cd2fdc97cb9c243ddac155698a132bcbdb22970910R91. Following-up in #1547.
bjaglin
force-pushed
the
fix-pprint
branch
5 times, most recently
from
de2e77d to
8731c79
Compare
Injecting instances of pprint.TPrint to customize the docs no longer has effect as of ffcd8b9, which was a silent breaking change. This commit exposes the breaking change so that rules built against the latest scalafix-core either drop usage of TPrint or switch to the shaded version which is used internally by metaconfig.
| ); | ||
| return fetch(repositories, Collections.singletonList(scalafixCli), ResolutionParams.create()); | ||
| // Coursier does not seem to fetch runtime dependencies transitively, despite what Maven dictates |
There was a problem hiding this comment.
I will follow up in coursier/coursier with a repro, since the scalafix CLIs installed by Coursier will most likely be unable to load old rules (just like the test was showing before this workaround was added) since they won't load pprint.
Running community rules with the CLI is probably not common anyway since it requires setting up the tool classpath yourself, so I think it's OK to break this until it's fixed in cs install/launch.
https://github.com/scalacenter/scalafix/runs/5184084825?check_suite_focus=true
[info] java.util.ServiceConfigurationError: scalafix.v1.Rule: Provider fix.SortImports could not be instantiated
[info] at java.util.ServiceLoader.fail(ServiceLoader.java:232)
[info] at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
[info] at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
[info] at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
[info] at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
[info] at scala.collection.convert.JavaCollectionWrappers$JIteratorWrapper.next(JavaCollectionWrappers.scala:38)
[info] at scala.collection.immutable.List.prependedAll(List.scala:156)
[info] at scala.collection.IterableOnceOps.toList(IterableOnce.scala:1251)
[info] at scala.collection.IterableOnceOps.toList$(IterableOnce.scala:1251)
[info] at scala.collection.AbstractIterator.toList(Iterator.scala:1293)
[info] ...
[info] Cause: java.lang.NoClassDefFoundError: pprint/TPrintColors
[info] at fix.SortImports.(SortImports.scala:30)
There was a problem hiding this comment.
Actually, it works as expected when using sonatype:
$ cs resolve -r sonatype:snapshots -r central --no-default ch.epfl.scala:scalafix-cli_2.13.8:0.9.34+25-b98e220d-SNAPSHOT:runtime | grep com.lihaoyi:pprint
com.lihaoyi:pprint_2.13:0.6.6:runtime
So the there shouldn't be any problem with CLI installed by coursier. There is however something fishy with ivy2local: coursier/coursier#2370. So the code added there is probably needed only for tests to pass, but it does not hurt anyway.
Follows #1530
Should unblock #1531
Injecting instances of
pprint.TPrintto customize the docs no longer has effect as of #1530, which was a silent breaking change. This commit exposes the breaking change so that rules built against the latest scalafix-core either drop usage ofTPrintor switch to the shaded version which is used internally by metaconfig.