Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Scala nightlies via system properties #1865

Merged
merged 1 commit into from
Sep 10, 2023
Merged

allow Scala nightlies via system properties #1865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import scala.util.Try
/* scalafmt: { maxColumn = 120 }*/

object Dependencies {
val scala212 = "2.12.18"
val scala213 = "2.13.12"
val scala3 = "3.3.1"
val scala212 = sys.props.getOrElse("scala212.nightly", "2.12.18")
val scala213 = sys.props.getOrElse("scala213.nightly", "2.13.12")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SethTisue I have suffixed the system property with the scala version to make it possible to tweak any scala version, I assume this is not a problem as it's explicitly forwarded there so it can easily be changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup that's fine

val scala3 = sys.props.getOrElse("scala3.nightly", "3.3.1")

val buildScalaVersions = Seq(scala212, scala213, scala3)
val buildWithTargetVersions: Seq[(String, String)] =
Expand Down