Log which file failed, clarify other files are still processed #908
Conversation
| @@ -266,6 +266,8 @@ object MainOps { | |||
| i += 1 | |||
| } | |||
| val next = handleFile(args, file) | |||
| if (next != ExitStatus.Ok) | |||
| args.args.out.println(s"Unexpected error handling '$file', proceeding to the next.") | |||
There was a problem hiding this comment.
I'm afraid this message could be noisy and still not give enough information to track what happened. I think it is better to report the actual error at the root, do you have a reproduction the situation you encountered?
There was a problem hiding this comment.
Sure: it happens when applying the 'Collection213CrossCompat' rules to akka. Enabling scalafix like this and running sbt 'akka-actor/scalafix Collection213CrossCompat' yields https://pastebin.com/NJ4N9xs9 (sorry about all the escape codes that get misrendered there).
This left me in the dark as to which file failed, and whether the scalafix process was aborted or continued after that. Of course having better errors nearer to the root would also be helpful, but perhaps not always practical.
There was a problem hiding this comment.
Thanks for providing those details, very helpful.
I opened #910 to improve handling of unexpected errors so that the message includes what file is relevant.
No description provided.