Renamed MdocSession.App to MdocSession.MdocApp #655
Conversation
There was a problem hiding this comment.
Thank you for this contribution! I am concerned that the name repl.MdocSession$MdocSessionAppBody is unnecessarily verbose given that it appears in all stack traces. I'm OK with changing the name but I'd prefer to use something shorter like ffun (or anything in that direction really). What do you think?
| @@ -299,8 +299,8 @@ class WorksheetSuite extends BaseSuite { | |||
| compat = Map( | |||
| Compat.Scala3 -> | |||
| """|crash:4:1: error: java.lang.RuntimeException: boom | |||
| | at repl.MdocSession$App.crash(crash.scala:7) | |||
| | at repl.MdocSession$App.<init>(crash.scala:15) | |||
| | at repl.MdocSession$MdocSessionAppBody.crash(crash.scala:7) | |||
There was a problem hiding this comment.
| | at repl.MdocSession$MdocSessionAppBody.crash(crash.scala:7) | |
| | at repl.MdocSession$MdocApp.crash(crash.scala:7) |
Maybe? Will be shorter a bit.
There was a problem hiding this comment.
Nice! just renamed it to your suggestion.
I considered other more generic names, but in the end I thought it would be simpler and more tolerant to name conflicts if it contains Mdoc in its name. |
hnaderi
changed the title
Appis a common name which conflicts with some codes and there is no meaningful workaround I think. so I renamed it to a more descriptive name that is also extremely hard to get ambiguous reference error from.it might resolve #204 too.