Workflow: run CI only native-image upon release #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, do not run CI when tagging; when the final commit of a release is merged, currently CI is invoked 3 times: - upon commit merge into main (triggered by push to branch main) - upon release (triggered by release published) - upon tagging along with release (triggered by push to tag `vX.Y.Z`) Let's remove the last trigger and run only native-image (which uploads release artifacts) on release trigger, as all the rest of the checks would have been run on the same commit when it had been originally pushed to main.
kitbellew
commented
Dec 27, 2024
| @@ -3,7 +3,7 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| tags: | |||
| tags_ignore: | |||
There was a problem hiding this comment.
perhaps this part should be completely removed, not sure
There was a problem hiding this comment.
Alternatively, we could remove the release below, no? Since when creating a release a tag is pushed anyway
There was a problem hiding this comment.
i think release published is needed since that's where it puts the assets. scalameta triggers just on tagging but it doesn't have assets.
tgodzik
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, do not run CI when tagging; when the final commit of a release is merged, currently CI is invoked 3 times:
vX.Y.Z)Let's remove the last trigger and run only native-image (which uploads release artifacts) on release trigger, as all the rest of the checks would have been run on the same commit when it had been originally pushed to main.