Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle renaming JdbcDatabaseConfig to JdbcConfig #30

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

brfrn169
Copy link
Collaborator

We need this fix for the following change:
scalar-labs/scalardb#247

Please take a look!

@brfrn169 brfrn169 requested a review from feeblefakie July 16, 2021 13:47
@brfrn169 brfrn169 self-assigned this Jul 16, 2021
@brfrn169 brfrn169 force-pushed the handle-renaming-jdbc-config branch from cc6f780 to 15b7a15 Compare July 16, 2021 23:23
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit fc714f5 into master Jul 20, 2021
@feeblefakie feeblefakie deleted the handle-renaming-jdbc-config branch July 20, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants