Fix Snapshot to handle deleteSet properly when a delete operation is mixed with other operations. #138
+177
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mixed with other operations
feeblefakie
changed the title
feeblefakie
changed the title
brfrn169
reviewed
Jan 21, 2021
| } | ||
|
|
||
| public Optional<TransactionResult> get(Snapshot.Key key) { | ||
| if (writeSet.containsKey(key)) { | ||
| throw new CrudRuntimeException("reading already written data is not allowed"); | ||
| } else if (deleteSet.containsKey(key)) { | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Why we allow reading already deleted data while we don't allow reading already written data?
There was a problem hiding this comment.
Thank you for the question!
This is because we can return empty for the already deleted records.
The reason why we throw an exception for reading already written data is we can't create Result from Put since Put might not have a full set of values.
There was a problem hiding this comment.
Ah okay. I understood. Thank you for the clear explanation! I'll approve this.
brfrn169
approved these changes
Jan 21, 2021
| } | ||
|
|
||
| public Optional<TransactionResult> get(Snapshot.Key key) { | ||
| if (writeSet.containsKey(key)) { | ||
| throw new CrudRuntimeException("reading already written data is not allowed"); | ||
| } else if (deleteSet.containsKey(key)) { | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Ah okay. I understood. Thank you for the clear explanation! I'll approve this.
|
@Yonezawa-T2 I'm mering it but PTAL when you get a chance since I might miss something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scalar-labs.atlassian.net/browse/DLT-7979