Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scalar-Schema] Set Cosmos secondary index #141

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jan 21, 2021

https://scalar-labs.atlassian.net/browse/DLT-8021

This PR is for Cosmos DB

For Cassandra: #140
For DynamoDB: #142

Please merge after #140

@yito88 yito88 added the enhancement New feature or request label Jan 21, 2021
@yito88 yito88 self-assigned this Jan 21, 2021
@yito88 yito88 changed the title Set Cosmos secondary index [Scalar-Schema] Set Cosmos secondary index Jan 21, 2021
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question, but it's just out of my curiosity. I'll approve this.

@@ -17,6 +17,7 @@
private String id;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of my curiosity. Why do we have CosmosTableMetadata in this schema tool project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class is used for metadata insertion.
Cosmos DB SDK serializes/deserializes the data according to this class's setter and getter.

This tool gives the instance to the Upsert API.

metadata (doto (CosmosTableMetadata.)

@feeblefakie feeblefakie merged commit 0f9cd90 into master Jan 22, 2021
@feeblefakie feeblefakie deleted the schema_cosmos_secondary_index branch January 22, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants